-
Notifications
You must be signed in to change notification settings - Fork 13
🐛 Fix template library install checks #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MFA-X-AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so for this, I'd like you to rework it so it doesn't add complexity. I don't like having to add another parameter to pass or introduce a silent state just for this one case. Let's just make it a simple, check if the template required libs are already installed, then if not, prompt the install.
…ified notifications
|
I've addressed your feedback and reworked this part as follows:
|
MFA-X-AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the PR!
Description
This PR addresses two issues with template library installation:
Duplicate prompts for already installed libraries
canon()function to normalize library names (e.g.,xai_flask→flask) before comparison.Multiple confirmation dialogs for missing libraries
handleInstall(..., { silent: true })to skip internal confirms and only show one confirmation to the user.Pull Request Type
Type of Change
Tests
1. Already installed libraries
Goal: Ensure templates no longer prompt for libraries that are already installed.
Steps:
xai_flasklibraries.2. Missing library
Goal: Confirm dialog appears only once when one library is missing.
Steps:
Uninstall or remove the
xai_agentandxai_openailibraries.Open Agent Template.
Verify:
AGENTandOPENAI.3. Cancel install
Goal: Verify user cancellation aborts correctly.
Steps:
Uninstall
xai_agent.Open Agent Template.
In the confirm dialog, click Cancel.
Verify:
Tested on? Specify Version.